Add support to create new Garden Linux canonical name instances from release files #305
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NotTheEvilOne
force-pushed
the
feature/enhance-cname-from-release-file
branch
from
b8a28b0 to
811ac1c
Compare
Related: #302 Signed-off-by: Tobias Wolf <wolf@b1-systems.de> On-behalf-of: SAP <tobias.wolf@sap.com>
NotTheEvilOne
force-pushed
the
feature/enhance-cname-from-release-file
branch
from
811ac1c to
5433f13
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #305 +/- ##
==========================================
+ Coverage 91.50% 91.73% +0.23%
==========================================
Files 42 42
Lines 2095 2105 +10
==========================================
+ Hits 1917 1931 +14
+ Misses 178 174 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
|
||
| artifacts_dir = Path(artifacts_dir) | ||
|
|
||
| cname_object = CName(cname) |
Contributor
There was a problem hiding this comment.
Here we could now drop the CName(cname) and instead directly use the CName.new_from_release_file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds support to create new GL canonical name instances from release files. This can be useful if no Garden Linux canonical name is known prior to instantiation.
Which issue(s) this PR fixes:
Related #302